impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Cherry-pick constant renaming for be/src/kudu from Kudu commit e719b
Date Tue, 22 Aug 2017 21:45:49 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: Cherry-pick constant renaming for be/src/kudu from Kudu commit e719b
......................................................................


Cherry-pick constant renaming for be/src/kudu from Kudu commit e719b

This change enforces the rule that constants under be/src/kudu directory
should be named kFooBar and fixes the cases where we didn't adhere to this.
This is needed to avoid conflicts when cherry-picking other changes.

Change-Id: I7971659ef3152580d44d6ddfb18be7ebf41052c7
Reviewed-on: http://gerrit.cloudera.org:8080/7158
Reviewed-by: Adar Dembo <adar@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-on: http://gerrit.cloudera.org:8080/7740
Reviewed-by: Henry Robinson <henry@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/kudu/rpc/protoc-gen-krpc.cc
M be/src/kudu/rpc/request_tracker-test.cc
M be/src/kudu/rpc/request_tracker.cc
M be/src/kudu/rpc/request_tracker.h
M be/src/kudu/rpc/retriable_rpc.h
M be/src/kudu/security/ca/cert_management.cc
M be/src/kudu/security/cert.cc
M be/src/kudu/security/crypto.cc
M be/src/kudu/security/openssl_util.h
M be/src/kudu/security/openssl_util_bio.h
M be/src/kudu/security/tls_context.cc
M be/src/kudu/util/debug/trace_event_impl.cc
M be/src/kudu/util/maintenance_manager.cc
M be/src/kudu/util/maintenance_manager.h
M be/src/kudu/util/mem_tracker-test.cc
M be/src/kudu/util/os-util.cc
M be/src/kudu/util/process_memory.cc
M be/src/kudu/util/rle-test.cc
18 files changed, 85 insertions(+), 85 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Henry Robinson: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/7740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7971659ef3152580d44d6ddfb18be7ebf41052c7
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Adar Dembo <adar@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>

Mime
View raw message