impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5784 : Separate planner and user set query options in profile
Date Tue, 22 Aug 2017 16:57:07 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5784 : Separate planner and user set query options in profile
......................................................................


Patch Set 1:

> (1 comment)
Relying to Dan and Balasz:

It's actually hard to determine what gets set where using the QueryOptions map thing we have
right now, mostly because of how inconsistent we are with default values. E.g. what if a property
is set in the session, then the planner sets it as well, but happens to set it to the default
value. Right now we can't even identify that as a non-default query option.

Obviously anything is possible with more changes, but we'd probably need to change how the
query options map works so that they have a standard scheme for providing default values and
are properly support composition and diff'ing, e.g. the planner sets the options = the new
map - the old map. 

Not bad to think about going down that path, but it'll be a bigger change and not for Impala
2.10. I think the safer thing is to print the maps more honestly (i.e. less special interpretation)
and settle on some names for these fields that we're happy with.

-- 
To view, visit http://gerrit.cloudera.org:8080/7721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfc7832963fa0bd278a45c06a5a54e1bf40d8876
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <jeszyb@gmail.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message