impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Knupp (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5820: Fix string format() syntax in test scanners fuzz.py
Date Tue, 22 Aug 2017 16:32:36 GMT
David Knupp has posted comments on this change.

Change subject: IMPALA-5820: Fix string format() syntax in test_scanners_fuzz.py
......................................................................


Patch Set 4:

I was stupid. I specifically tested my patch against the RELEASE build, which didn't need
Tim's dcheck fix for IMPALA-5819. However, when this change was tested upstream, it ran against
a DEBUG build, and without Tim's change, it failed.

-- 
To view, visit http://gerrit.cloudera.org:8080/7761
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5384aaf83a6a1f3c7643ed9f15de2dba1a5913a5
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message