impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5784 : Separate planner and user set query options in profile
Date Tue, 22 Aug 2017 00:59:16 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5784 : Separate planner and user set query options in profile
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7721/1/be/src/service/client-request-state.cc
File be/src/service/client-request-state.cc:

Line 151:   summary_profile_.AddInfoString("Query Options (non default, after planning)",
this is probably okay, but i wonder if it'd be clearer if we instead either:
A) just have mutually exclusive lists where the options set by the impala are in one list
and options set by the user/session are in the other list.
B) have a single list where options set by Impala are marked with an asterisk or something.
if that's much complexity, maybe not worth it. also interested to hear what others think about
which is easier to read.


-- 
To view, visit http://gerrit.cloudera.org:8080/7721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfc7832963fa0bd278a45c06a5a54e1bf40d8876
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message