impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Knupp (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5820: Fix string format() syntax in test scanners fuzz.py
Date Mon, 21 Aug 2017 23:42:45 GMT
David Knupp has uploaded a new patch set (#3).

Change subject: IMPALA-5820: Fix string format() syntax in test_scanners_fuzz.py
......................................................................

IMPALA-5820: Fix string format() syntax in test_scanners_fuzz.py

Make the call to format() compatible with older versions of python
(< 2.7), which expect an indices in the string being formatted,
e.g. "{0} {1} {2}".format('foo', 'bar', 'baz'). Without the numbers,
format() raises an exception.

Tested by running this test suite using python 2.6.6. Before the
patch, the tests failed. After the patch, they pass.

Change-Id: I5384aaf83a6a1f3c7643ed9f15de2dba1a5913a5
---
M tests/query_test/test_scanners_fuzz.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/7761/3
-- 
To view, visit http://gerrit.cloudera.org:8080/7761
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5384aaf83a6a1f3c7643ed9f15de2dba1a5913a5
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>

Mime
View raw message