impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5641: mem-estimate should never be less than mem-reservation
Date Mon, 21 Aug 2017 20:37:45 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5641: mem-estimate should never be less than mem-reservation
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7703/4/fe/src/main/java/org/apache/impala/planner/ResourceProfileBuilder.java
File fe/src/main/java/org/apache/impala/planner/ResourceProfileBuilder.java:

Line 42:    * the minimum reservation is used as the memory estimate instead.
> This comment is probably better in ResourceProfile itself.
There's already a comment in ResourceProfile saying that memEstimateBytes_ >= minReservationBytes_.
Do you think we'd be better just deleting this comment?


-- 
To view, visit http://gerrit.cloudera.org:8080/7703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e2853300371e31b13d81a763dbafb21709b16c4
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message