impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Cherry-pick constant renaming for be/src/kudu from Kudu commit e719b
Date Mon, 21 Aug 2017 18:23:06 GMT
Michael Ho has posted comments on this change.

Change subject: Cherry-pick constant renaming for be/src/kudu from Kudu commit e719b
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7740/2//COMMIT_MSG
Commit Message:

PS2, Line 7: tidy: enable rule for constant naming
> Right, but it a) doesn't apply to our whole codebase, so it isn't really a 
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7971659ef3152580d44d6ddfb18be7ebf41052c7
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Adar Dembo <adar@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message