impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] tidy: enable rule for constant naming
Date Mon, 21 Aug 2017 18:09:03 GMT
Michael Ho has posted comments on this change.

Change subject: tidy: enable rule for constant naming
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7740/2//COMMIT_MSG
Commit Message:

PS2, Line 7: tidy: enable rule for constant naming
> sorry to harp on this, but this isn't accurate. Where is the rule 'enabled'
In some sense, the rule is the use of kFooBar. May be it's better to use the word enforce
in our context.


-- 
To view, visit http://gerrit.cloudera.org:8080/7740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7971659ef3152580d44d6ddfb18be7ebf41052c7
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Adar Dembo <adar@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message