impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] tidy: enable rule for constant naming
Date Mon, 21 Aug 2017 17:48:48 GMT
Hello Adar Dembo, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/7740

to look at the new patch set (#2).

Change subject: tidy: enable rule for constant naming
......................................................................

tidy: enable rule for constant naming

This is a cherry-pick of kudu commit e719b5eff2a47f61f9e6ee1f18d2055247f45847

This change enforces constants under be/src/kudu directory should
be named kFooBar and fixes the cases where we didn't adhere to this.
This is needed to avoid conflicts when cherry-picking

Change-Id: I7971659ef3152580d44d6ddfb18be7ebf41052c7
Reviewed-on: http://gerrit.cloudera.org:8080/7158
Reviewed-by: Adar Dembo <adar@cloudera.com>
Tested-by: Kudu Jenkins
---
M be/src/kudu/rpc/protoc-gen-krpc.cc
M be/src/kudu/rpc/request_tracker-test.cc
M be/src/kudu/rpc/request_tracker.cc
M be/src/kudu/rpc/request_tracker.h
M be/src/kudu/rpc/retriable_rpc.h
M be/src/kudu/security/ca/cert_management.cc
M be/src/kudu/security/cert.cc
M be/src/kudu/security/crypto.cc
M be/src/kudu/security/openssl_util.h
M be/src/kudu/security/openssl_util_bio.h
M be/src/kudu/security/tls_context.cc
M be/src/kudu/util/debug/trace_event_impl.cc
M be/src/kudu/util/maintenance_manager.cc
M be/src/kudu/util/maintenance_manager.h
M be/src/kudu/util/mem_tracker-test.cc
M be/src/kudu/util/os-util.cc
M be/src/kudu/util/process_memory.cc
M be/src/kudu/util/rle-test.cc
18 files changed, 85 insertions(+), 85 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/7740/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7740
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7971659ef3152580d44d6ddfb18be7ebf41052c7
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Adar Dembo <adar@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>

Mime
View raw message