impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5800: [Addendum] Fix bad import of squeasel.c
Date Mon, 21 Aug 2017 05:32:01 GMT
Henry Robinson has uploaded a new patch set (#2).

Change subject: IMPALA-5800: [Addendum] Fix bad import of squeasel.c
......................................................................

IMPALA-5800: [Addendum] Fix bad import of squeasel.c

The previous commit for IMPALA-5800 imported a slightly old version of
squeasel.c from the upstream project. In particular, the strings used to
choose the TLS version were incompatible with Impala's. This patch
corrects the error.

Testing: Add tests to make sure that the expected flags are supported by
Squeasel.

Change-Id: I03b76f2d3b3e2e6133e5c57a4f33ac315c889e15
---
M be/src/thirdparty/squeasel/squeasel.c
M be/src/util/webserver-test.cc
2 files changed, 33 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/7752/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7752
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I03b76f2d3b3e2e6133e5c57a4f33ac315c889e15
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins

Mime
View raw message