impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages
Date Fri, 18 Aug 2017 21:29:15 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-5811: Add 'backends' tab to query details pages
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7711/1/be/src/runtime/coordinator-backend-state.cc
File be/src/runtime/coordinator-backend-state.cc:

Line 556:   value->AddMember("num_instances", fragments_.size(), document->GetAllocator());
> I couldn't find a very easy way to plumb it through. Perhaps we could leave
hmm, I'm ok with it. May be add a TODO if you think its worth adding in the future.


-- 
To view, visit http://gerrit.cloudera.org:8080/7711
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5b3b0fb8f4188da56da593199f41ce6fab99767
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message