impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5602: Fix query optimization for kudu and datasource tables
Date Thu, 17 Aug 2017 21:27:45 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5602: Fix query optimization for kudu and datasource tables
......................................................................


Patch Set 4: Code-Review+1

(4 comments)

Let's see if Alex and or Tim want to take another look

http://gerrit.cloudera.org:8080/#/c/7560/4/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java
File fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java:

Line 367:   public boolean hasPushedConjuncts(){ return !acceptedConjuncts_.isEmpty(); }
formatting


http://gerrit.cloudera.org:8080/#/c/7560/4/testdata/workloads/functional-query/queries/QueryTest/data-source-tables.test
File testdata/workloads/functional-query/queries/QueryTest/data-source-tables.test:

PS4, Line 138: s(
can you put the full key here, i.e. + "(non default)" or whatever? That way we'll be sure
to update it after IMPALA-5784 and then I think this will become a more convincing test case
because we know the planner was the one that set this option.


http://gerrit.cloudera.org:8080/#/c/7560/4/tests/query_test/test_kudu.py
File tests/query_test/test_kudu.py:

PS4, Line 1005: creating table
creating a table.


PS4, Line 1010: "T
JIRA number:


-- 
To view, visit http://gerrit.cloudera.org:8080/7560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I93822d67ebda41d5d0456095c429e3915a3f40c4
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message