impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build
Date Thu, 17 Aug 2017 20:19:38 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
......................................................................


Patch Set 12:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5719/12//COMMIT_MSG
Commit Message:

PS12, Line 11: One minor linking change to krpc/CMakeLists.txt.
> Stale ?
Done


http://gerrit.cloudera.org:8080/#/c/5719/12/be/CMakeLists.txt
File be/CMakeLists.txt:

PS12, Line 341:  histogram_proto
> This is used by kudu/util/metrics.cc, right ?
Yes.


-- 
To view, visit http://gerrit.cloudera.org:8080/5719
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33203e95dff07c87a6ec5c7a31b7a583b91849bc
Gerrit-PatchSet: 12
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message