impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5158,IMPALA-5236: account for unused buffer pool reservations
Date Wed, 16 Aug 2017 23:57:06 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5158,IMPALA-5236: account for unused buffer pool reservations
......................................................................


Patch Set 6:

> So just to recap, does it work as the immediate solution if I:
 > * Convert all the memory metrics to IntGauge
 > * Leave the unused reservation metric as it is in the current patch
 > * Create a derived metric for the MemTracker's use that simply
 > negates the unused reservation metric.
 > * Remove the negation logic from MemTracker

Works for me.

-- 
To view, visit http://gerrit.cloudera.org:8080/7380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb1fa3110dc893321f9f4e8ced6b7ede12194dad
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message