impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-2615: support [[nodiscard]] on Status
Date Wed, 16 Aug 2017 23:23:29 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-2615: support [[nodiscard]] on Status
......................................................................


Patch Set 14: Code-Review+2

(1 comment)

Seems okay to me, though maybe we could improve the name of StartServices(). It doesn't make
a lot of sense to me, what do you think?

http://gerrit.cloudera.org:8080/#/c/7253/14/be/src/runtime/exec-env.cc
File be/src/runtime/exec-env.cc:

PS14, Line 211: StartServices
this name seems kinda weird for what it does. Should this just be called Init()?


-- 
To view, visit http://gerrit.cloudera.org:8080/7253
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I972543af2e9f98b12dcbb5479b4c1a7d53952197
Gerrit-PatchSet: 14
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message