impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5644: Reject queries if min reservation is too large
Date Wed, 16 Aug 2017 22:24:00 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5644: Reject queries if min reservation is too large
......................................................................


Patch Set 1:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/7678/1/be/src/scheduling/admission-controller.cc
File be/src/scheduling/admission-controller.cc:

PS1, Line 445: GetProcMemLimit
> I thought about it, though I think we should hold off for now. This check i
Ah ok, makes sense. Yeah I think there's a lot of opportunity for improvement.


http://gerrit.cloudera.org:8080/#/c/7678/2/be/src/scheduling/admission-controller.cc
File be/src/scheduling/admission-controller.cc:

Line 401:     }
I was wondering about whether it makes sense to report which backend had the max reservation.

My feeling is that the additional info isn't actionable so isn't worth including.


Line 430:     *rejection_reason = REASON_DISABLED_MAX_MEM_RESOURCES;
It seems like this would fit better in ReservationUtil.


Line 432:   } else if (pool_cfg.max_mem_resources > 0 &&
I think the test is only exercising the second MEM_MIN_REMAINING calculation. Might be good
to have a simple unit test (e.g. in reservation-tracker-test) to check a couple more values
of the calculation.


http://gerrit.cloudera.org:8080/#/c/7678/2/be/src/scheduling/admission-controller.h
File be/src/scheduling/admission-controller.h:

PS2, Line 465: set
maybe "set to a explanation of why the request was rejected".


-- 
To view, visit http://gerrit.cloudera.org:8080/7678
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iabe87ce8f460356cfe4d1be4d7092c5900f9d79b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message