impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5158,IMPALA-5236: account for unused buffer pool reservations
Date Wed, 16 Aug 2017 21:05:31 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5158,IMPALA-5236: account for unused buffer pool reservations
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7380/6//COMMIT_MSG
Commit Message:

PS6, Line 29: -8.25 MB
> Hm, though this metric will show up in our UI and (with the plumbing) in CM
It seems weird having the user-visible metric be a negative quantity. We could have an internal-only
negative metric that is used for this purpose only.

We'd then need to switch MemTracker to taking an IntGauge.

How about replacing all of the memory metrics with IntGauge and doing away with UIntGauge?
I don't think we need the extra positive range in any cases.


-- 
To view, visit http://gerrit.cloudera.org:8080/7380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb1fa3110dc893321f9f4e8ced6b7ede12194dad
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message