impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5158,IMPALA-5236: account for unused buffer pool reservations
Date Wed, 16 Aug 2017 19:33:10 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5158,IMPALA-5236: account for unused buffer pool reservations
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7380/6//COMMIT_MSG
Commit Message:

After staring at it for a while, I see why this makes sense and fixes the accounting.

That said, I have a few questions--maybe not code changes but things to think about:
what does this mean for the user? what to do if there's a big gap here? what is a big gap?

can this be tracked at the query level? then it's easier to see what queries/pools are reserving
more memory than they're actually using


PS6, Line 29: -8.25 MB
> Yeah that was my thought, it made it easier to see how the total related to
Hm, though this metric will show up in our UI and (with the plumbing) in CM as a positive
value. It might make sense to just have this metric be an IntGauge where it can be set negative
consistently, then we also don't need special logic in the mem-tracker.


-- 
To view, visit http://gerrit.cloudera.org:8080/7380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb1fa3110dc893321f9f4e8ced6b7ede12194dad
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message