impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5158,IMPALA-5236: account for unused buffer pool reservations
Date Wed, 16 Aug 2017 19:06:07 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5158,IMPALA-5236: account for unused buffer pool reservations
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7380/6//COMMIT_MSG
Commit Message:

Line 14:       reservation + cached buffers - unused reservation
> For the second, don't you already compute it in BufferPoolMetric::Calculate
Yeah that's true (for some reason I wasn't thinking about that).

So it's really just the first reason.


PS6, Line 29: -8.25 MB
> On the other hand, maybe having the negative there makes it clearer that ev
Yeah that was my thought, it made it easier to see how the total related to the components.


-- 
To view, visit http://gerrit.cloudera.org:8080/7380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb1fa3110dc893321f9f4e8ced6b7ede12194dad
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message