impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5800: Configure Squeasel's cipher suite and TLS version
Date Wed, 16 Aug 2017 18:43:00 GMT
Sailesh Mukil has posted comments on this change.

Change subject: IMPALA-5800: Configure Squeasel's cipher suite and TLS version

Patch Set 2:

Commit Message:

PS1, Line 10:
> It's the right commit - a bugfix for the previous one.
I would add a reference to this as well, to avoid confusion:
File be/src/thirdparty/squeasel/squeasel.c:

Line 4232: #endif
> I don't think that's what happens - won't the 'else' branch below get taken
Oops, brainfart, you're right.
File be/src/thirdparty/squeasel/squeasel.c:

PS2, Line 4275: ctx->config[SSL_CIPHERS]
In our case, this will never be NULL right? Since our ssl_cipher_list flag defaults to an
empty string:

Do we know how OpenSSL handles an empty string? I tried looking up the docs but couldn't find
any references.
File be/src/util/

PS2, Line 251: SslBadCipherSuite
Thanks for adding the test. This shouldn't be called "SslBadCipherSuite" now though. Your
call on whether you want to split the good test out or just have a more accommodating test

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I23fb17257098992c65e50c1e83a905c9a85db6a2
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <>
Gerrit-Reviewer: Henry Robinson <>
Gerrit-Reviewer: Sailesh Mukil <>
Gerrit-HasComments: Yes

View raw message