impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5158,IMPALA-5236: account for unused buffer pool reservations
Date Wed, 16 Aug 2017 17:33:56 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5158,IMPALA-5236: account for unused buffer pool reservations
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7380/6//COMMIT_MSG
Commit Message:

Line 14:       reservation + cached buffers - unused reservation
> It doesn't help here for a couple of reasons:
For the second, don't you already compute it in BufferPoolMetric::CalculateValue() as an intermediate
value?


PS6, Line 29: -8.25 MB
why do we want that to be negative? in the above equation, the value itself is positive but
subtracted by the equation, and that makes sense. It seems -8.25MB of "unused reservation"
is confusing -- does that mean we have a deficit of unused?

Maybe it would be clearer to show this as positive. We could make the new boolean just apply
to how LogUsage() sums up the children, rather than the consumption value itself.  That also
mirrors the equation you wrote. What do you think?


-- 
To view, visit http://gerrit.cloudera.org:8080/7380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb1fa3110dc893321f9f4e8ced6b7ede12194dad
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message