impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4786: Clean up how ImpalaServers are created
Date Wed, 16 Aug 2017 16:23:41 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4786: Clean up how ImpalaServers are created
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7673/1/be/src/testutil/in-process-servers.cc
File be/src/testutil/in-process-servers.cc:

Line 96:   RETURN_IF_ERROR(exec_env_->Init());
I hit a bug in expr-test here where StartServices() starts up the statestore subscriber but
ImpalaServer tries to subscribe to topics below, which is invalid after it's started.

Not sure what that means for this patch but you'll see a rebase conflict for sure. It seems
like the dependency between ExecEnv::Init() and other things is non-trivial.


-- 
To view, visit http://gerrit.cloudera.org:8080/7673
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d55fbe0f4f7a1fd48993da46863b66e521feaae
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message