impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-2615: support [[nodiscard]] on Status
Date Wed, 16 Aug 2017 01:21:16 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-2615: support [[nodiscard]] on Status
......................................................................


Patch Set 10: Code-Review+2

(1 comment)

Rebase

http://gerrit.cloudera.org:8080/#/c/7253/9/be/src/util/runtime-profile.cc
File be/src/util/runtime-profile.cc:

Line 748:       MakeScopeExitTrigger([&compressor]() { compressor->Close(); });
> i prefer goto, but up to you.
Ok, I'll leave as-is, seems slightly less error-prone in this context.


-- 
To view, visit http://gerrit.cloudera.org:8080/7253
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I972543af2e9f98b12dcbb5479b4c1a7d53952197
Gerrit-PatchSet: 10
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message