impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3200: More end-to-end tests
Date Wed, 16 Aug 2017 00:14:10 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3200: More end-to-end tests
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7668/2/tests/verifiers/metric_verifier.py
File tests/verifiers/metric_verifier.py:

PS2, Line 33:                "buffer-pool.clean-pages",
            :                "buffer-pool.clean-page-bytes"
> these will get checked in tests/verifiers/test_verify_metrics.py now -- but
Added a comment. Clean pages should be zero as soon as there are no queries running, since
pages only exist as long as they are owned by a query. Free buffers don't belong to a query.


-- 
To view, visit http://gerrit.cloudera.org:8080/7668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a3b6adf5b97b16594c6c4855d5fa831c5a90e10
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message