impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tianyi Wang (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-992: Rerun past queries from history in shell
Date Tue, 15 Aug 2017 22:26:27 GMT
Tianyi Wang has posted comments on this change.

Change subject: IMPALA-992: Rerun past queries from history in shell
......................................................................


Patch Set 5:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/7674/5//COMMIT_MSG
Commit Message:

Line 9: This patch adds a new command "rerun" and shortcut "@" to impala-shell.
> nit: and a shortcut.
Done


Line 10: User can rerun a certain query by its index given by history command.
> nit: users...
Done


PS5, Line 12: Negavie
> typo
Done


http://gerrit.cloudera.org:8080/#/c/7674/5/shell/impala_shell.py
File shell/impala_shell.py:

PS5, Line 1105: format
> I think this should be aligned with the . under the " according to PEP8.
Done.


Line 1111:     # Remove the semicolon at last.
> I think this comment now is not needed anymore, the command looks self expl
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7674
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc28e8ce07845343267224c3b9ccb71b29a524d2
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang <twang@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <twang@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message