impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tianyi Wang (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-992: Rerun past queries from history in shell
Date Tue, 15 Aug 2017 22:04:47 GMT
Tianyi Wang has posted comments on this change.

Change subject: IMPALA-992: Rerun past queries from history in shell
......................................................................


Patch Set 5:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/7674/4/shell/impala_shell.py
File shell/impala_shell.py:

Line 1089:     """Rerun a command with an command index in history
> Unless you're trying to achieve something special, you can just have the st
Thanks. I should have noticed the syntax looking around in this file.


PS4, Line 1164:  original
> nit: characters
Done


PS4, Line 1166: their aliases.
              :     """
> I'd probably leave out this sentence since it'll be hard to keep this in sy
Removed.


-- 
To view, visit http://gerrit.cloudera.org:8080/7674
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc28e8ce07845343267224c3b9ccb71b29a524d2
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang <twang@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <twang@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message