impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5769: Add periodic minidump cleanup
Date Tue, 15 Aug 2017 21:44:11 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-5769: Add periodic minidump cleanup

Patch Set 2:


Thanks for the reviews. Please see PS3.
File tests/custom_cluster/

Line 233:     assert self.wait_for_num_processes('impalad', cluster_size) == cluster_size
> Isn't this racy? Since the minidump rotator could wake up before this runs.
I'm not sure I understand your concern. Breakpad forks to write the minidump, so for a short
period there are more impalad processes. We wait for these processes to be gone; afterwards
all minidumps will be written. Then we wait an additional rotation_interval+1 seconds and
only then do we count the number of minidump files.

Line 237:     expected_impalads = min(self.get_num_processes('impalad'), self.MAX_MINIDUMPS)
> expected_impalad_minidumps might be clearer.

PS2, Line 239: 2
> This relates to rotation_interval, so should probably be expressed as rotat

Line 241:     assert self.count_minidumps('statestored') == 1
> Can we also test sending multiple SIGUSR1 signals to the cluster to make su

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie02ff2271412d814f84a4ff42ccbca51d91bf980
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <>
Gerrit-Reviewer: Lars Volker <>
Gerrit-Reviewer: Sailesh Mukil <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message