impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tianyi Wang (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-992: Rerun past queries from history in shell
Date Tue, 15 Aug 2017 21:23:03 GMT
Tianyi Wang has uploaded a new patch set (#3).

Change subject: IMPALA-992: Rerun past queries from history in shell
......................................................................

IMPALA-992: Rerun past queries from history in shell

This patch adds a new command "rerun" and shortcut "@" to impala-shell.
User can rerun a certain query by its index given by history command.
Negavie values index history in reverse order. For example, "@1;" or
"rerun 1;" reruns the first query shown in history and "@-1;" reruns
the last query. The rerun command itself won't appear in history.
The history index is 1-based increasing and the old entries might be
truncated when impala-shell starts, so the same index may not refer the
same command.

Testing: A test case test_rerun is added to
shell/test_shell_interactive.py

Change-Id: Ifc28e8ce07845343267224c3b9ccb71b29a524d2
---
M shell/impala_shell.py
M tests/shell/test_shell_interactive.py
2 files changed, 85 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/7674/3
-- 
To view, visit http://gerrit.cloudera.org:8080/7674
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifc28e8ce07845343267224c3b9ccb71b29a524d2
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang <twang@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>

Mime
View raw message