impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5644: Reject queries if min reservation is too large
Date Tue, 15 Aug 2017 18:34:55 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5644: Reject queries if min reservation is too large
......................................................................


Patch Set 1:

(4 comments)

The overall approach makes sense to me. Commented on the aspects of it that weren't covered
by the TODOs that you left.

http://gerrit.cloudera.org:8080/#/c/7678/1/be/src/runtime/bufferpool/reservation-util.cc
File be/src/runtime/bufferpool/reservation-util.cc:

Line 23:   const double ReservationUtil::RESERVATION_MEM_FRACTION = 0.8;
We don't normally indent inside namespaces.


http://gerrit.cloudera.org:8080/#/c/7678/1/be/src/runtime/query-state.cc
File be/src/runtime/query-state.cc:

Line 153:   if (query_options().__isset.buffer_pool_limit
The logic in admission control should also take into account buffer_pool_limit. I think that
may break the approach used in test_initial_reservation() to test failure to acquire initial
reservation, but I have an alternative test here that would test the initial reservation exceeding
the process limit:

https://gerrit.cloudera.org/#/c/7668/


http://gerrit.cloudera.org:8080/#/c/7678/1/be/src/scheduling/admission-controller.cc
File be/src/scheduling/admission-controller.cc:

Line 428:   // Checks related to pool max_mem_resources:
Is there a reason behind the order of the checks? Might be helpful to document.


PS1, Line 445: GetProcMemLimit
Should we also be comparing the reservation against the process memory limit?


-- 
To view, visit http://gerrit.cloudera.org:8080/7678
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iabe87ce8f460356cfe4d1be4d7092c5900f9d79b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message