impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5769: Add periodic minidump cleanup
Date Tue, 15 Aug 2017 18:13:13 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5769: Add periodic minidump cleanup
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/7605/2/tests/custom_cluster/test_breakpad.py
File tests/custom_cluster/test_breakpad.py:

Line 233:     assert self.wait_for_num_processes('impalad', cluster_size) == cluster_size
Isn't this racy? Since the minidump rotator could wake up before this runs.


Line 237:     expected_impalads = min(self.get_num_processes('impalad'), self.MAX_MINIDUMPS)
expected_impalad_minidumps might be clearer.


PS2, Line 239: 2
This relates to rotation_interval, so should probably be expressed as rotation_interval +
1


Line 241:     assert self.count_minidumps('statestored') == 1
Can we also test sending multiple SIGUSR1 signals to the cluster to make sure that the log
rotator is running for the other processes.


-- 
To view, visit http://gerrit.cloudera.org:8080/7605
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie02ff2271412d814f84a4ff42ccbca51d91bf980
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message