impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5598: Fix excessive dumping in MemLimitExceeded
Date Tue, 15 Aug 2017 17:59:22 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5598: Fix excessive dumping in MemLimitExceeded
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7597/3/be/src/runtime/mem-tracker.cc
File be/src/runtime/mem-tracker.cc:

PS3, Line 353: logged_query_tracker
rather than introducing another control variable, why not just 'state == nullptr'? the comment
explains it (especially if you make the comment order match the code order of conditionals).


http://gerrit.cloudera.org:8080/#/c/7597/3/be/src/runtime/mem-tracker.h
File be/src/runtime/mem-tracker.h:

PS3, Line 338: summary of the queries
does this mean it it dumps the query-level tracker but nothing below? if so, maybe be more
explicit about this.


-- 
To view, visit http://gerrit.cloudera.org:8080/7597
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib151c3894d4c43b508779e6809d77e2f8af89cf2
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message