impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Impala-992: Rerun past queries from history in shell
Date Tue, 15 Aug 2017 17:54:26 GMT
Lars Volker has posted comments on this change.

Change subject: Impala-992: Rerun past queries from history in shell
......................................................................


Patch Set 2:

(9 comments)

http://gerrit.cloudera.org:8080/#/c/7674/2//COMMIT_MSG
Commit Message:

PS2, Line 7: Impala
nit: capitalize


PS2, Line 9: @
What's the reason for picking "@" over "!"? The latter is used in shells and was suggested
in the JIRA.


PS2, Line 12: History index is 1-based.
Can you give a usage example? Does the history count backwards or forwards in time?


http://gerrit.cloudera.org:8080/#/c/7674/2/shell/impala_shell.py
File shell/impala_shell.py:

PS2, Line 79: object
Why is this needed?


Line 1073:     else:
nit: You can remove the else and unindent the block, just like you do in the next method.


PS2, Line 1090: \n
Format on two lines to make it easier to read.


Line 1107:     return self.onecmd(cmd[:-1])
Does it always have a semicolon? .rstrip(";") might be more robust and clearer in its intention.


Line 1156:     """Parse the line into a command name and a string containing
Can you mention that this method will perform transformations?


PS2, Line 1157: line
what will 'line' contain?


-- 
To view, visit http://gerrit.cloudera.org:8080/7674
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc28e8ce07845343267224c3b9ccb71b29a524d2
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang <twang@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message