impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] [DOCS] Fold some <codeblock> lines
Date Tue, 15 Aug 2017 17:43:35 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: [DOCS] Fold some <codeblock> lines
......................................................................


[DOCS] Fold some <codeblock> lines

Putting <codeblock> on a separate line causes an extra
leading blank line in PDF output. (I think that's a
bug in the PDF transform, but what can you do...)

I took one file that had a few instances of such
examples, and folded the first line of the code
example onto the same line as the <codeblock> tag.

Using this minor change to demo upstream -> downstream
cherry-picking techniques.

Change-Id: I563a71ab9e59c691264c1f6a088e71f4722d3097
Reviewed-on: http://gerrit.cloudera.org:8080/7417
Reviewed-by: Michael Brown <mikeb@cloudera.com>
Reviewed-by: Laurel Hale <laurel@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/topics/impala_connecting.xml
1 file changed, 3 insertions(+), 6 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Michael Brown: Looks good to me, approved
  Laurel Hale: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.cloudera.org:8080/7417
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I563a71ab9e59c691264c1f6a088e71f4722d3097
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <ambreen.kazi@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Laurel Hale <laurel@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>

Mime
View raw message