impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taras Bobrovytsky (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5776: Write partial tuple to the correct mempool
Date Tue, 15 Aug 2017 01:45:23 GMT
Taras Bobrovytsky has posted comments on this change.

Change subject: IMPALA-5776: Write partial tuple to the correct mempool

Patch Set 3:

File be/src/exec/

Line 804:       // Copy over all materialized slots in the partial tuple.
> Only describes what the code does. How about something like:

Line 808:       // prevent the accumulation of variable length data in it. We also recreate
> The partial tuple isn't re-created here
File be/src/exec/hdfs-text-scanner.h:

Line 186:   /// Utility function to write out 'num_fields' to 'tuple_'.  This is used to parse
> Comment is weird, I suggest rephrasing to something like:

Line 227:   /// Mem pool for the partial tuple.
> Mention that it does not hold tuple data of returned batches because the da

Line 230:   /// Memory to store partial tuples split across buffers.  Memory comes from
> Mention that this tuple is always deep copied into the output batch

Line 231:   /// partial_tuple_pool_.  There is only one tuple allocated for this object and
> The 2nd sentence does not seem to apply anymore because we realloc the part

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I60ba5c113aefd17f697c1888fd46a237ef396540
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Taras Bobrovytsky <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message