impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [native-toolchain-CR] IMPALA-5477: Fix minidump-2-core tool in breakpad
Date Tue, 15 Aug 2017 00:36:50 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7658/2/buildall.sh
File buildall.sh:

Line 273: BREAKPAD_VERSION=1b704857f1e78a864e6942e613457e55f1aecb60-p3 $SOURCE_DIR/source/breakpad/build.sh
Can you move the old version into BUILD_HISTORICAL for consistency with elsewhere? 

It's not super-important but good to be consistent.


-- 
To view, visit http://gerrit.cloudera.org:8080/7658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iafe8cb59316bbec0a2c829f278a23a48238ad6e2
Gerrit-PatchSet: 2
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message