impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5769: Add periodic minidump cleanup
Date Tue, 15 Aug 2017 00:30:54 GMT
Hello Sailesh Mukil,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/7605

to look at the new patch set (#2).

Change subject: IMPALA-5769: Add periodic minidump cleanup
......................................................................

IMPALA-5769: Add periodic minidump cleanup

Minidumps can be written by sending SIGUSR1 to our daemon processes.
That way, an arbitrary number of minidump files can be created. This
change adds minidump cleanup to the periodic log file cleanup to
effectively bound the maximum number of minidumps we keep around.

Change-Id: Ie02ff2271412d814f84a4ff42ccbca51d91bf980
---
M be/src/common/init.cc
M be/src/util/minidump.cc
M be/src/util/minidump.h
M tests/custom_cluster/test_breakpad.py
4 files changed, 47 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/05/7605/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7605
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie02ff2271412d814f84a4ff42ccbca51d91bf980
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>

Mime
View raw message