impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5769: Add periodic minidump cleanup
Date Mon, 14 Aug 2017 23:45:21 GMT
Sailesh Mukil has posted comments on this change.

Change subject: IMPALA-5769: Add periodic minidump cleanup
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7605/1/be/src/util/minidump.cc
File be/src/util/minidump.cc:

PS1, Line 113: CheckAndRemoveMinidumps
nit: Maybe we should call this "CheckAndRotateMinidumps" to be consistent with the other log
rotation functions?

Your call though, I'd be fine with this name too.


-- 
To view, visit http://gerrit.cloudera.org:8080/7605
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie02ff2271412d814f84a4ff42ccbca51d91bf980
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message