impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar
Date Mon, 14 Aug 2017 18:42:23 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar
......................................................................


Patch Set 8: Code-Review+2

(2 comments)

Looks good. If you fix the last couple of nits and rebase I can start the merge.

http://gerrit.cloudera.org:8080/#/c/7642/8/be/src/util/jni-util.h
File be/src/util/jni-util.h:

Line 164:   DISALLOW_COPY_AND_ASSIGN(JniUtfCharGuard);
Nit: move it inside 'private'.


http://gerrit.cloudera.org:8080/#/c/7642/8/be/src/util/logging-support.cc
File be/src/util/logging-support.cc:

Line 53:     str = "";
Nit: seems simpler to just initialise it to point to the empty string constant like it was
before.


-- 
To view, visit http://gerrit.cloudera.org:8080/7642
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I47eed045f21c6ed3a8decf422ce8429fc66c4322
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang <twang@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <twang@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message