impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5666: ASAN poisoning for MemPool and BufferPool
Date Fri, 11 Aug 2017 23:12:35 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-5666: ASAN poisoning for MemPool and BufferPool
......................................................................


Patch Set 3:

This patch fixes two issues over the previous patch: 

1. Fix quadratic behaviour when reallocating from a free pool - previously the patch would
poison the entire chunk, and then unpoison the allocated bytes. We can do better by tracking
the size of the allocation, and then only unpoisoning the bytes that are newly allocated after
the reallocate call (or poisoning them if the allocation shrinks). This fixes an issue where
test_very_large_strings would take hours and hours to execute: it now takes about 6 minutes
on my machine.

2. ADDRESS_SANITIZER was not defined in codegen-compiled code. Added -DADDRESS_SANITIZER to
CMAKE_CXX_IR_FLAGS.

-- 
To view, visit http://gerrit.cloudera.org:8080/7591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8d5a28dfee2b7c631981aac75524bde9acc0b36a
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message