impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tianyi Wang (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5327: Handle return of JNI GetStringUTFChar
Date Fri, 11 Aug 2017 22:02:53 GMT
Tianyi Wang has posted comments on this change.

Change subject: IMPALA-5327: Handle return of JNI GetStringUTFChar
......................................................................


Patch Set 8:

> (4 comments)
 > 
 > Yeah, we use Status almost universally for error handling. We don't
 > currently distinguish very clearly between internal-only status
 > codes and user-visible status codes.
 > 
 > Thanks for adding this class, should make this error handling less
 > error-prone.

Done

-- 
To view, visit http://gerrit.cloudera.org:8080/7642
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I47eed045f21c6ed3a8decf422ce8429fc66c4322
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang <twang@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <twang@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message