impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4833: Compute precise per-host reservation size
Date Fri, 11 Aug 2017 21:34:48 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4833: Compute precise per-host reservation size
......................................................................


Patch Set 4: Code-Review+1

(3 comments)

Looks good to me. Not sure if Lars wants to take a look too.

http://gerrit.cloudera.org:8080/#/c/7630/4/be/src/scheduling/admission-controller.cc
File be/src/scheduling/admission-controller.cc:

Line 342:   for (const auto& entry : per_backend_params) {
Nit: I think this will fit if you just do:
           for (const auto& entry : schedule.per_backend_exec_params()) {


http://gerrit.cloudera.org:8080/#/c/7630/4/be/src/scheduling/query-schedule.h
File be/src/scheduling/query-schedule.h:

Line 24: #include <boost/unordered_set.hpp>
This include might not be needed any more.


http://gerrit.cloudera.org:8080/#/c/7630/4/tests/custom_cluster/test_mem_reservations.py
File tests/custom_cluster/test_mem_reservations.py:

Line 32:   def test_per_backend_min_reservation(self, vector):
Nice!


-- 
To view, visit http://gerrit.cloudera.org:8080/7630
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idbcd1e9b1be14edc4017b4907e83f9d56059fbac
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message