impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5773: Correctly account for memory used in data stream receiver queue
Date Fri, 11 Aug 2017 19:38:40 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-5773: Correctly account for memory used in data stream receiver queue
......................................................................


Patch Set 3:

(2 comments)

I didn't notice any significant performance regressions when I ran TPCDS on a 16-node cluster.
But this is an obvious correctness issue; we'll do more perf analysis shortly.

http://gerrit.cloudera.org:8080/#/c/7646/3/be/src/runtime/data-stream-mgr.cc
File be/src/runtime/data-stream-mgr.cc:

PS3, Line 80:  int buffer_size
> For consistency, should this be int64_t too ?
Done


http://gerrit.cloudera.org:8080/#/c/7646/3/be/src/runtime/data-stream-recvr.cc
File be/src/runtime/data-stream-recvr.cc:

PS3, Line 154: int64_t batch_size = RowBatch::GetDeserializedSize(thrift_batch);
> nit: move this closer to l165 where it's used
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7646
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e90f9596ee984438e3373af05e84d361702ca6a
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message