impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5791: Make bootstrap development.sh survive apt-get failure
Date Fri, 11 Aug 2017 19:24:35 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-5791: Make bootstrap_development.sh survive apt-get failure
......................................................................


IMPALA-5791: Make bootstrap_development.sh survive apt-get failure

This patch adds quadratic backoff to apt-get, which can fail for
network reasons.

While I'm here, fix bug in call to diff: diff returns failure when
there is a difference, but it is used in this script only for the
output, not the return value.

Change-Id: I2829064c9f27c39f13529b3d1a1e4f7d7a0e0128
Reviewed-on: http://gerrit.cloudera.org:8080/7657
Reviewed-by: Michael Brown <mikeb@cloudera.com>
Tested-by: Impala Public Jenkins
---
M bin/bootstrap_development.sh
1 file changed, 22 insertions(+), 8 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Michael Brown: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/7657
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2829064c9f27c39f13529b3d1a1e4f7d7a0e0128
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>

Mime
View raw message