impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [native-toolchain-CR] IMPALA-5477: Fix minidump-2-core tool in breakpad
Date Fri, 11 Aug 2017 18:00:35 GMT
Lars Volker has uploaded a new patch set (#2).

Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad
......................................................................

IMPALA-5477: Fix minidump-2-core tool in breakpad

The recent PPC port broke the minidump-2-core tool in the toolchain.
This change undoes a seemingly erroneous #ifdef to fix the tool on
non-PPC systems.

To test this, I built a toolchain locally and made sure that cores
created from minidumps with the tool can be opened by GDB.

I didn't test the change on PPC.

Change-Id: Iafe8cb59316bbec0a2c829f278a23a48238ad6e2
---
M buildall.sh
A source/breakpad/breakpad-1b704857f1e78a864e6942e613457e55f1aecb60-patches/0003-fix-md2core.patch
2 files changed, 20 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/58/7658/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iafe8cb59316bbec0a2c829f278a23a48238ad6e2
Gerrit-PatchSet: 2
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>

Mime
View raw message