impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [native-toolchain-CR] IMPALA-5477: Fix minidump-2-core tool in breakpad
Date Fri, 11 Aug 2017 17:46:27 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-5477: Fix minidump-2-core tool in breakpad
......................................................................


Patch Set 1:

> Do you think should add this as a separate patch, rather than
 > updating an existing one? That way there's no confusion about which
 > version we have installed.

I don't feel strongly about either. Currently not a lot of people use the tool and with the
next update of the upstream version it'll be resolved for everyone. If you think it's worth
the effort, I can prepare a subsequent patch and we can squash them on the next upstream version
bump.

-- 
To view, visit http://gerrit.cloudera.org:8080/7658
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iafe8cb59316bbec0a2c829f278a23a48238ad6e2
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message