impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5708: Test failure with invalid exec summary
Date Fri, 11 Aug 2017 17:00:16 GMT
Thomas Tauber-Marshall has uploaded a new patch set (#2).

Change subject: IMPALA-5708: Test failure with invalid exec summary
......................................................................

IMPALA-5708: Test failure with invalid exec summary

For some queries, the exec summary will not be completely filled
in even if the query is FINISHED. In particular, the exec_stats field
may not be set. This was causing an error in our test code that
converts the exec summary to a more usable format.

The situation is essentially deterministic for some queries, but
it was being hidden by testing code that caught the error and
discarded it in most situations, leading to flaky tests.

This patch removes the 'try' that was hiding the error and makes
the code check for the presence of exec_stats and handle it rather
than generating an error.

I filed IMPALA-5783 for followup work to be more rigorous about
when the exec summary should and shouldn't be fully present.

Testing:
- Ran the affected tests in a loop and they are no longer flaky.

Change-Id: Id52ac62da2b01f9e163e97cbe4590f8db6b663d2
---
M shell/impala_client.py
M tests/beeswax/impala_beeswax.py
2 files changed, 22 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/7627/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id52ac62da2b01f9e163e97cbe4590f8db6b663d2
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>

Mime
View raw message