impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4863/IMPALA-5311: Correctly account the file type and compression codec
Date Wed, 09 Aug 2017 23:59:17 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4863/IMPALA-5311: Correctly account the file type and compression codec
......................................................................


Patch Set 5:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/7245/5/be/src/exec/hdfs-scan-node-base.cc
File be/src/exec/hdfs-scan-node-base.cc:

Line 885:             ss << file_format << "/" << "Unknown"<< "(Skipped):"
<< it->second << " ";
nit: missing space before <<


PS5, Line 888: <<
nit: align <<'s vertically (it's in the style guide somewhere).


http://gerrit.cloudera.org:8080/#/c/7245/5/testdata/workloads/functional-query/queries/QueryTest/hdfs_scanner_profile.test
File testdata/workloads/functional-query/queries/QueryTest/hdfs_scanner_profile.test:

Line 9: ---- QUERY
I missed this in an earlier pass but we don't have a regression test for IMPALA-4863. Can
we add tests for the runtime filter partition case, maybe for both text and parquet. E.g.
this query works for me:

set runtime_filter_wait_time_ms=100000;
select count(*) 
from tpcds.store_sales
join tpcds.date_dim on ss_sold_date_sk = d_date_sk
where d_qoy=1


-- 
To view, visit http://gerrit.cloudera.org:8080/7245
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I797916505f62e568f4159e07099481b8ff571da2
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <aphadke@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: anujphadke <aphadke@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message