impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pranay Singh (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-1478: Improve error message when subquery is used in the ON clause
Date Tue, 08 Aug 2017 22:39:49 GMT
Pranay Singh has posted comments on this change.

Change subject: IMPALA-1478: Improve error message when subquery is used in the ON clause
......................................................................


Patch Set 3:

(4 comments)

Addressed the comments

http://gerrit.cloudera.org:8080/#/c/7588/1//COMMIT_MSG
Commit Message:

PS1, Line 7: IMPALA-
> Could you replace it with the jira ID?  Typically we include jira ID in the
Done


PS1, Line 10:      Add test case for testing the failure when a subquery is used in th
> Move above the change-Id.
Done


http://gerrit.cloudera.org:8080/#/c/7588/3//COMMIT_MSG
Commit Message:

Line 10:      Add test case for testing the failure when a subquery is used in the ON clause.
> nit: limit to 70chars per line in commit messages.
Done


PS3, Line 12: Change-Id: I05f4223fe6862fdb22fb2343ccb1f9070e32c5ff
> Remove. (Gerrit's commit hook uses the change-Id to map the commit to the c
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7588
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0d1dc47987de7ea04402e1ead31d81cddf2f96f2
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Pranay Singh
Gerrit-HasComments: Yes

Mime
View raw message