impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5661: buffer pool limit
Date Mon, 07 Aug 2017 22:41:16 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5661: buffer pool limit
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7462/4//COMMIT_MSG
Commit Message:

Line 7: IMPALA-5661: buffer pool limit
> Add "Adds a ... flag" or similar
Done


http://gerrit.cloudera.org:8080/#/c/7462/4/be/src/common/global-flags.cc
File be/src/common/global-flags.cc:

PS4, Line 49: specified "
            :     "as number of bytes ('<int>[bB]?'), megabytes ('<float>[mM]'),
"
            :     "gigabytes ('<float>[gG]'), or percentage of the process memory limit
('<int>%'). "
            :     "Defaults to bytes if no unit is given.
> can you factor out this string that we repeat constantly in gflag descripti
Done. I could only find 3 instances of it.


-- 
To view, visit http://gerrit.cloudera.org:8080/7462
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia64e21e0d5a7cf35a9064f365c6c86db13fbd73d
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message