impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5768: Better developer documentation
Date Mon, 07 Aug 2017 20:13:51 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5768: Better developer documentation
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

LGTM. I'll give other reviewers a chance to weigh in.

http://gerrit.cloudera.org:8080/#/c/7350/4/README.md
File README.md:

Line 105: | SENTRY_HOME          | "${CDH_COMPONENTS_HOME}/toolchain/" | |
Should this be /sentry-?? or something?


-- 
To view, visit http://gerrit.cloudera.org:8080/7350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16d34cb4fa0c60c5ad6d9c8764cc0ec21c5cb368
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <zamsden@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message